Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Fix .codecov.yaml #22633

Merged
merged 2 commits into from Jun 1, 2019
Merged

馃悰 Fix .codecov.yaml #22633

merged 2 commits into from Jun 1, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Jun 1, 2019

We recently enabled PR statuses from codecov in order to improve AMP's code coverage. It appears the settings in .codecov.yaml are not taking effect.

PR comments:

amphtml/.codecov.yml

Lines 3 to 4 in 9c4ec35

# See https://docs.codecov.io/docs/pull-request-comments
comment: off

PR statuses:

amphtml/.codecov.yml

Lines 6 to 16 in 9c4ec35

# See https://docs.codecov.io/v4.3.0/docs/commit-status
coverage:
status:
project:
base: auto # Use base commit for PRs, parent commit for push builds
target: auto # Target same coverage as the base / parent commit
threshold: 100 # Passing check no matter what the coverage is
patch:
base: auto # Use base commit for PRs, parent commit for push builds
target: 100 # Target 100% coverage for diffs
threshold: 100 # Passing check no matter what the coverage is

This PR rewrites the .codecov.yaml file using the latest recommended format at https://docs.codecov.io/docs

@rsimha rsimha requested review from aghassemi and lannka June 1, 2019 17:59
@rsimha rsimha self-assigned this Jun 1, 2019
@rsimha rsimha changed the title 馃悰 Fix .codecov.yaml to properly disable PR comments 馃悰 Fix .codecov.yaml Jun 1, 2019
@rsimha
Copy link
Contributor Author

rsimha commented Jun 1, 2019

This worked.

Screen Shot 2019-06-01 at 3 41 55 PM

Merging to unblock incoming PRs.

@rsimha rsimha merged commit 986f9cd into ampproject:master Jun 1, 2019
@rsimha rsimha deleted the 2019-06-01-CodecovYaml branch June 1, 2019 19:18
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants