✨ Introduce new tick event cls (Cumulative Layout Shift).
#23200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be removed when the definition is released in closure-compiler.
jridgewell
approved these changes
Jul 16, 2019
rindo
pushed a commit
to logly/amphtml
that referenced
this pull request
Jul 24, 2019
…ct#23200) * Introduce new tick event `cls` (Cumulative Layout Shift). Fixes ampproject#23154 * Add CLS to tickevent docs * Lint fixes * Add PerformanceObserver.supportedEntryTypes type def. This should be removed when the definition is released in closure-compiler. * Fix stubbing of supportedEntryTypes property * PerformanceObserver is not defined in headless browser test environment * empty
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
…ct#23200) * Introduce new tick event `cls` (Cumulative Layout Shift). Fixes ampproject#23154 * Add CLS to tickevent docs * Lint fixes * Add PerformanceObserver.supportedEntryTypes type def. This should be removed when the definition is released in closure-compiler. * Fix stubbing of supportedEntryTypes property * PerformanceObserver is not defined in headless browser test environment * empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23154
This introduces a bit of duplication with existing code for layout jank support. I've suggested we remove layout jank support in ~a month, see #23198.