Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Introduce video-ad-start/end event #23733
Thank you for the quick review! This is not a feature that's specific to ima video.
@rsimha I noticed one more issue with
Currently, we pick up entry-point-level changes for core runtime code, and directory level changes for extensions. This file appears to be violating both conventions.
Aug 6, 2019
14 of 16 checks passed
I'm thinking about the same. One easy workaround is to hard code the files when the component is identified as a video component.