Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Do not require amp-autocomplete to be a child of a form #23800

Merged
merged 2 commits into from Aug 8, 2019

Conversation

@cvializ
Copy link
Contributor

commented Aug 7, 2019

Fixes #23657

@cvializ cvializ requested review from sparhami and nainar Aug 7, 2019

@googlebot googlebot added the cla: yes label Aug 7, 2019

<input>
<script type="application/json"> {} </script>
</amp-autocomplete>
<!-- Valid: input and script tags as direct child to FORM -->

This comment has been minimized.

Copy link
@sparhami

sparhami Aug 7, 2019

Contributor

should update comments here and below, these are not a direct child of form

@cvializ cvializ force-pushed the cvializ:validator/relax-autocomplete branch from 906471a to 434a5bc Aug 8, 2019

@cvializ cvializ merged commit 12d14ae into ampproject:master Aug 8, 2019

13 of 15 checks passed

ampproject/pr-deploy Ready to create a test site.
Details
ampproject/tests/unit (local-changes) Tests were not required
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
ampproject/bundle-size Δ +0.00KB | no approval necessary
Details
ampproject/tests/e2e (local) 308 tests passed
Details
ampproject/tests/integration (local) 271 tests passed
Details
ampproject/tests/integration (saucelabs) 420 tests passed
Details
ampproject/tests/integration (single-pass) 213 tests passed
Details
ampproject/tests/unit (local) 10120 tests passed
Details
ampproject/tests/unit (saucelabs) 7848 tests passed
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing 55480e2...434a5bc
Details
codecov/project 79.46% remains the same compared to 55480e2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
percy/amphtml Visual review automatically approved, no visual changes found.
Details
Gregable added a commit to Gregable/amphtml that referenced this pull request Aug 8, 2019
erwinmombay added a commit that referenced this pull request Aug 8, 2019
Validator rollup (#23835)
* cl/262363476 Add width and height attributes to the svg SYMBOL tag validation rules.

* cl/262384419 Revision bump for #23406

* cl/262398573 Revision bump for #23393

* cl/262415464 Add devmode validation logic.

* cl/262420139 s/amphtml-dev-mode/ampdevmode/ in our error strings.

* cl/262430869 Convert python scripts to be python3 compatible.

* cl/262440817 Revision bump for #23800

* cl/262442134 Revision bump for #23826
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
Do not require amp-autocomplete to be a child of a form (ampproject#…
…23800)

* Do not require amp-autocomplete to be a child of a form

* Fix inaccurate comment
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
Validator rollup (ampproject#23835)
* cl/262363476 Add width and height attributes to the svg SYMBOL tag validation rules.

* cl/262384419 Revision bump for ampproject#23406

* cl/262398573 Revision bump for ampproject#23393

* cl/262415464 Add devmode validation logic.

* cl/262420139 s/amphtml-dev-mode/ampdevmode/ in our error strings.

* cl/262430869 Convert python scripts to be python3 compatible.

* cl/262440817 Revision bump for ampproject#23800

* cl/262442134 Revision bump for ampproject#23826
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.