Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validator Rollup #23802

Merged
merged 10 commits into from Aug 8, 2019
Next

cl/261776511 Add ValidationError::DEV_MODE_ONLY error code.

  • Loading branch information...
Gregable committed Aug 7, 2019
commit d48d6d2de4e1ea2f183a9735d65120a31b5e433a
@@ -26,7 +26,7 @@ min_validator_revision_required: 375
# newer versions of the spec file. This is currently a Google internal
# mechanism, validator.js does not use this facility. However, any
# change to this file (validator-main.js) requires updating this revision id.
spec_file_revision: 920
spec_file_revision: 921

styles_spec_url: "https://amp.dev/documentation/guides-and-tutorials/develop/style_and_layout/style_pages"
script_spec_url: "https://amp.dev/documentation/guides-and-tutorials/learn/spec/amphtml#html-tags"
@@ -6867,6 +6867,14 @@ error_specificity {
code: DOCUMENT_SIZE_LIMIT_EXCEEDED
specificity: 120
}
error_specificity {
code: DEV_MODE_ONLY
# This should always trump any other error. It is asserting
# that the developer intends for this tag to be an error but
# that no additional errors should be reported for this tag.
specificity: 1000
}

# Error formats
error_formats {
code: UNKNOWN_CODE
@@ -7331,3 +7339,8 @@ error_formats {
code: DOCUMENT_SIZE_LIMIT_EXCEEDED
format: "Document exceeded %1 bytes limit. Actual size %2 bytes."
}
error_formats {
code: DEV_MODE_ONLY
format: "Tag 'html' marked with attribute 'amphtml-dev-mode'. Validator "
"will suppress errors regarding any other tag with this attribute."
}
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.