Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix amp-date-picker closure compiler warnings #23806

Merged
merged 1 commit into from Aug 8, 2019

Conversation

@cvializ
Copy link
Contributor

commented Aug 7, 2019

Fixes #23429

It turns out the solution was to make Closure Compiler stop checking the extends and to use ES5 class syntax with manual prototype chaining. Not ideal, but at least it's an established pattern that works.

@cvializ cvializ requested review from sparhami and rsimha Aug 7, 2019

@googlebot googlebot added the cla: yes label Aug 7, 2019

@rsimha
rsimha approved these changes Aug 8, 2019
Copy link
Collaborator

left a comment

Thanks for the fix!

@cvializ cvializ force-pushed the cvializ:fix/adp-types branch from ca18d8a to ecf0714 Aug 8, 2019

@cvializ cvializ merged commit 1091059 into ampproject:master Aug 8, 2019

14 of 15 checks passed

ampproject/pr-deploy Ready to create a test site.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
ampproject/bundle-size Δ +0.00KB | no approval necessary
Details
ampproject/tests/e2e (local) 308 tests passed
Details
ampproject/tests/integration (local) 271 tests passed
Details
ampproject/tests/integration (saucelabs) 420 tests passed
Details
ampproject/tests/integration (single-pass) 213 tests passed
Details
ampproject/tests/unit (local) 10120 tests passed
Details
ampproject/tests/unit (local-changes) 4 tests passed
Details
ampproject/tests/unit (saucelabs) 7848 tests passed
Details
cla/google All necessary CLAs are signed
codecov/patch 98.79% of diff hit (within 100% threshold of 100%)
Details
codecov/project 79.48% (+0.01%) compared to 55480e2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
percy/amphtml Visual review automatically approved, no visual changes found.
Details
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.