Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move expiration date back to 2020 #23809

Merged
merged 3 commits into from Aug 8, 2019

Conversation

@estherkim
Copy link
Contributor

commented Aug 8, 2019

Current experimentA config is now "expired".

@googlebot googlebot added the cla: yes label Aug 8, 2019

@estherkim estherkim requested review from jonathantyng-amp and zhouyx Aug 8, 2019

@cvializ
cvializ approved these changes Aug 8, 2019
Copy link
Contributor

left a comment

LGTM

@zhouyx
zhouyx approved these changes Aug 8, 2019
@@ -3,7 +3,7 @@
"name": "ANALYTICS_VENDOR_SPLIT",
"command": "gulp generate-vendor-jsons && gulp dist --defineExperimentConstant=ANALYTICS_VENDOR_SPLIT",
"issue": "",
"expirationDateUTC": "2019-08-08",
"expirationDateUTC": "2020-08-08",

This comment has been minimized.

Copy link
@zhouyx

zhouyx Aug 8, 2019

Contributor

: ) Thank you Esther! While this is not documented yet because we haven't official announced the support. But the idea is that each experiment should be limited to a month. Can we change it to 2019-09-08 instead? Thanks

This comment has been minimized.

Copy link
@estherkim

estherkim Aug 8, 2019

Author Contributor

Sure - but when this expires it will fail our builds because gulp update-packages fails. I'm guessing that's not desired behavior?

This comment has been minimized.

Copy link
@zhouyx

zhouyx Aug 8, 2019

Contributor

Interesting. It should fail gulp build, but I don't understand why it would fail gulp update-packages.
We are expecting to run the experiment for 2 weeks. One month should be enough. I think the idea is to update the experiment data with another PR if we are going to run the experiment longer.

This comment has been minimized.

Copy link
@rsimha

rsimha Aug 8, 2019

Collaborator

+1 to what @estherkim said. An expired experiment shouldn't fail unrelated gulp tasks, so maybe the check could be moved to its own task that's run separately on Travis?

This comment has been minimized.

Copy link
@zhouyx

zhouyx Aug 8, 2019

Contributor

Agreed to only throw error when there's --defineExperimentConstant flag exist.

@zhouyx
zhouyx approved these changes Aug 8, 2019
Copy link
Contributor

left a comment

Thank you for the fix!!!

@cramforce cramforce merged commit 3314dbb into ampproject:master Aug 8, 2019

12 of 16 checks passed

ampproject/bundle-size Failed to retrieve the bundle size of branch point 8df2209
Details
ampproject/owners-check ampproject/owners-check
Details
ampproject/pr-deploy Ready to create a test site.
Details
ampproject/tests/unit (local-changes) Tests were not required
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
ampproject/tests/e2e (local) 308 tests passed
Details
ampproject/tests/integration (local) 271 tests passed
Details
ampproject/tests/integration (saucelabs) 420 tests passed
Details
ampproject/tests/integration (single-pass) 213 tests passed
Details
ampproject/tests/unit (local) 10120 tests passed
Details
ampproject/tests/unit (saucelabs) 7848 tests passed
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected.
Details
codecov/project No report found to compare against
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
percy/amphtml Visual review automatically approved, no visual changes found.
Details

@rsimha rsimha added the WG: infra label Aug 8, 2019

@estherkim estherkim deleted the estherkim:expiration-date branch Aug 9, 2019

choumx added a commit that referenced this pull request Aug 12, 2019
Move expiration date back to 2020 (#23809)
* move date to 2020

* update date and dont throw

* actually throw if using --defineExperimentConstant
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
Move expiration date back to 2020 (ampproject#23809)
* move date to 2020

* update date and dont throw

* actually throw if using --defineExperimentConstant
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.