Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰鉁╜<amp-carousel>` 0.2 minor fixes #23821

Merged
merged 4 commits into from Aug 8, 2019

Conversation

@sparhami
Copy link
Contributor

commented Aug 8, 2019

  • Support initial (non-bound) value for slide (for #11734)
  • Fix toggleAutoplay when no argument is specified
  • Stop propagation on touchmove like carousel 0.1 so it does not cause a viewer swipe

@googlebot googlebot added the cla: yes label Aug 8, 2019

@sparhami sparhami requested a review from cvializ Aug 8, 2019

@cvializ
cvializ approved these changes Aug 8, 2019
Copy link
Contributor

left a comment

LGTM

@sparhami sparhami merged commit c6fbe85 into ampproject:master Aug 8, 2019

14 of 16 checks passed

ampproject/owners-check ampproject/owners-check
Details
ampproject/pr-deploy Ready to create a test site.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
ampproject/bundle-size 螖 +0.00KB | no approval necessary
Details
ampproject/tests/e2e (local) 308 tests passed
Details
ampproject/tests/integration (local) 271 tests passed
Details
ampproject/tests/integration (saucelabs) 420 tests passed
Details
ampproject/tests/integration (single-pass) 213 tests passed
Details
ampproject/tests/unit (local) 10120 tests passed
Details
ampproject/tests/unit (local-changes) 15 tests passed
Details
ampproject/tests/unit (saucelabs) 7848 tests passed
Details
cla/google All necessary CLAs are signed
codecov/patch 50% of diff hit (within 100% threshold of 100%)
Details
codecov/project 79.45% (-0.01%) compared to 6880626
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
percy/amphtml Visual review automatically approved, no visual changes found.
Details
Gregable added a commit to Gregable/amphtml that referenced this pull request Aug 15, 2019
Gregable added a commit to Gregable/amphtml that referenced this pull request Aug 15, 2019
Partial validator rollup (ampproject#23996)
* cl/262449237 Fix equality check in build.py.

* cl/262459103 Revision bump for ampproject#23821
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
馃悰`<amp-carousel>` 0.2 minor fixes (ampproject#23821)
* Support initial slide attribute.
* Fix no-argument autoplay for carousel 0.2
* Stop touchmove from propagating like amp-carousel 0.1.
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
Partial validator rollup (ampproject#23996)
* cl/262449237 Fix equality check in build.py.

* cl/262459103 Revision bump for ampproject#23821
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.