Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摉Update documentation for carousel 0.2 #23840

Merged
merged 8 commits into from Aug 9, 2019

Conversation

@sparhami
Copy link
Contributor

commented Aug 8, 2019

  • Move the 0.1 documentation into the 0.1 folder, add a link from the new documentation to the version on Github.
  • Update the documentation to reflect the current state of carousel 0.2, with migration notes.
  • Fix a few things in the documentation that were not correct for either 0.1 or 0.2.
  • Move the validator tests into the 0.2 folder since the validator rules match 0.2.
  • Remove the type slides/carousel distinction in the validator spec, the code no longer has a distinction for allowed layouts, autoplay, etc.

Closes #4642
Closes #5977
Closes #9882
Closes #11734
Closes #11797
Closes #14505
Closes #15181
Closes #15822
Closes #17318
Closes #17741
Closes #20374
Closes #20685

/cc @nainar @CrystalOnScript

sparhami added 5 commits Aug 8, 2019
Update documentation for carousel 0.2.
- Update the documentation to reflect the current state of carousel 0.2, with migration notes.
- Fix a few thing in the documentation that were not correct for either 0.1 or 0.2.
- Move the 0.1 documentation into the 0.1 folder, add a link from the new documentation to the version on Github.
- Move the validator tests into the 0.2 folder since the validator rules match 0.2.
- Remove the type slides/carousel destinction in the validator spec, the code no longer has a distinction for allowed layouts, autoplay, etc.

@googlebot googlebot added the cla: yes label Aug 8, 2019

@CrystalOnScript
Copy link
Collaborator

left a comment

Added some nits

<li>carousel: fixed, fixed-height, and nodisplay.</li>
<li>slides: fill, fixed, fixed-height, flex-item, nodisplay, and responsive.</li>
</ul>
fill, fixed, fixed-height, flex-item, intrinsic, nodisplay, and responsive.

This comment has been minimized.

Copy link
@CrystalOnScript

CrystalOnScript Aug 8, 2019

Collaborator

Are the examples below relevant to V2 or are they strictly V1?

This comment has been minimized.

Copy link
@sparhami

sparhami Aug 8, 2019

Author Contributor

They are relevant to both v1 and v2 (with a minor tweak to one of the examples for v2).

extensions/amp-carousel/amp-carousel.md Outdated Show resolved Hide resolved
extensions/amp-carousel/amp-carousel.md Outdated Show resolved Hide resolved
extensions/amp-carousel/amp-carousel.md Outdated Show resolved Hide resolved
extensions/amp-carousel/amp-carousel.md Outdated Show resolved Hide resolved
extensions/amp-carousel/amp-carousel.md Outdated Show resolved Hide resolved
sparhami added 2 commits Aug 8, 2019

@sparhami sparhami requested a review from Gregable Aug 8, 2019

@sparhami sparhami marked this pull request as ready for review Aug 8, 2019

@sparhami sparhami requested a review from cvializ Aug 9, 2019

@cvializ
cvializ approved these changes Aug 9, 2019
Copy link
Contributor

left a comment

LGTM

@sparhami sparhami merged commit dc0001b into ampproject:master Aug 9, 2019

13 of 16 checks passed

ampproject/owners-check ampproject/owners-check
Details
ampproject/pr-deploy Ready to create a test site.
Details
ampproject/tests/unit (local-changes) Tests were not required
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
ampproject/bundle-size 螖 -0.01KB | no approval necessary
Details
ampproject/tests/e2e (local) 308 tests passed
Details
ampproject/tests/integration (local) 270 tests passed
Details
ampproject/tests/integration (saucelabs) 417 tests passed
Details
ampproject/tests/integration (single-pass) 212 tests passed
Details
ampproject/tests/unit (local) 10121 tests passed
Details
ampproject/tests/unit (saucelabs) 7848 tests passed
Details
cla/google All necessary CLAs are signed
codecov/patch Coverage not affected when comparing 600a7da...3dcf1ad
Details
codecov/project 79.43% (+<.01%) compared to 600a7da
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
percy/amphtml Visual review automatically approved, no visual changes found.
Details
sparhami added a commit that referenced this pull request Aug 14, 2019
sparhami added a commit that referenced this pull request Aug 15, 2019
choumx added a commit that referenced this pull request Aug 15, 2019
Gregable added a commit to Gregable/amphtml that referenced this pull request Aug 15, 2019
Gregable added a commit that referenced this pull request Aug 16, 2019
Validator rollup (#24000)
* cl/262591581 Revision bump for #23840

* cl/262631527 Revision bump for #23765

* cl/263233041 data-ampdevmode. Avoid using non-data attributes on non-custom elements.

* cl/263556980 Allow nonce on `<link rel=stylesheet>`.

* cl/263618983 Revision bump for #23775

* cl/263623541 Revision bump for #23873

* cl/263628558 Revision bump for #23866

* cl/263637721 Revision bump for #23867

* cl/263656022 Revision bump for #23967

* fix reverse sync

* fix reverse sync
sparhami added a commit that referenced this pull request Aug 16, 2019
sparhami added a commit that referenced this pull request Aug 16, 2019
westonruter added a commit to westonruter/amphtml that referenced this pull request Aug 17, 2019
Merge branch 'master' of github.com:ampproject/amphtml into allow/nos鈥
鈥ript-img-with-http-protocol

* 'master' of github.com:ampproject/amphtml: (1326 commits)
  Fix and enable e2e tests for AMPHTML ads FIE rendering mode (ampproject#23995)
  馃彈 Update WorkerDOM to 0.17.0 (ampproject#24024)
  Make DocInfo.pageViewId64 async (ampproject#23998)
  馃悰 Updates amp-sidebar in amp-story  (ampproject#23956)
  Revert "Revert "馃摉Update documentation for carousel 0.2 (ampproject#23840)" (ampproject#23967)" (ampproject#24016)
  馃敟 Revert "馃搱 Initial StorySpec Implementation (ampproject#23030)" (ampproject#24013)
  Extension skeleton code for payment widgets (ampproject#23045)
  馃彈馃悰 Don't call `travisBuildNumber()` in the global scope (ampproject#24021)
  Remove suppressTypes from amp-mustache. (ampproject#23993)
  馃悰 Move `terser` from `dependencies` to `devDependencies` (ampproject#24018)
  Revert "Revert "Set the new loaders experiment to 1% of traffic. (ampproject#23780)" (ampproject#23963)" (ampproject#24014)
  SwG release 0.1.22.63 (ampproject#23997)
  Resolve navTiming variable earlier if possible (ampproject#23580)
  馃彈 Don't run all the runtime tests for validator-only changes (ampproject#24010)
  Collect document ready signal (ampproject#23981)
  Validator rollup (ampproject#24000)
  Remove flaky story branching test. (ampproject#23994)
  Include amp-base-carousel in amp-carousel's build. (ampproject#23984)
  Partial validator rollup (ampproject#23996)
  amp-bind: Rate-limit history operations (ampproject#23938)
  ...
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
馃摉Update documentation for carousel 0.2 (ampproject#23840)
- Move the 0.1 documentation into the 0.1 folder, add a link from the new documentation to the version on Github.
- Update the documentation to reflect the current state of carousel 0.2, with migration notes.
- Fix a few things in the documentation that were not correct for either 0.1 or 0.2.
- Move the validator tests into the 0.2 folder since the validator rules match 0.2.
- Remove the type slides/carousel distinction in the validator spec, the code no longer has a distinction for allowed layouts, autoplay, etc.
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
Validator rollup (ampproject#24000)
* cl/262591581 Revision bump for ampproject#23840

* cl/262631527 Revision bump for ampproject#23765

* cl/263233041 data-ampdevmode. Avoid using non-data attributes on non-custom elements.

* cl/263556980 Allow nonce on `<link rel=stylesheet>`.

* cl/263618983 Revision bump for ampproject#23775

* cl/263623541 Revision bump for ampproject#23873

* cl/263628558 Revision bump for ampproject#23866

* cl/263637721 Revision bump for ampproject#23867

* cl/263656022 Revision bump for ampproject#23967

* fix reverse sync

* fix reverse sync
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.