Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix navigation in PWAs / webpages saved to homescreen #23844

Merged
merged 5 commits into from Aug 9, 2019

Conversation

@cvializ
Copy link
Contributor

commented Aug 8, 2019

Fixes #3835
Fixes #3861

This PR approached the problem by adding a dedicated extension for this use case to avoid increasing bundle size for code that will run in only a few use-cases.

/to @sparhami
/to @sebastianbenz

cvializ added 3 commits Aug 8, 2019

@cvializ cvializ requested review from sebastianbenz and sparhami Aug 8, 2019

@googlebot googlebot added the cla: yes label Aug 8, 2019

cvializ added 2 commits Aug 9, 2019

@cvializ cvializ force-pushed the cvializ:feature/amp-standalone branch from acf0013 to 785a3ae Aug 9, 2019

@cvializ cvializ merged commit 4e6d1a5 into ampproject:master Aug 9, 2019

12 of 13 checks passed

ampproject/pr-deploy Ready to create a test site.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
ampproject/bundle-size Δ +0.10KB | no approval necessary
Details
ampproject/tests/e2e (local) 308 tests passed
Details
ampproject/tests/integration (local) 270 tests passed
Details
ampproject/tests/integration (saucelabs) 417 tests passed
Details
ampproject/tests/integration (single-pass) 212 tests passed
Details
ampproject/tests/unit (local) 10129 tests passed
Details
ampproject/tests/unit (local-changes) 5501 tests passed
Details
ampproject/tests/unit (saucelabs) 7848 tests passed
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
percy/amphtml Visual review automatically approved, no visual changes found.
Details
@sebastianbenz

This comment has been minimized.

Copy link
Collaborator

commented Aug 9, 2019

Woohoo!

@cramforce cramforce referenced this pull request Aug 12, 2019
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
Fix navigation in PWAs / webpages saved to homescreen (ampproject#23844)
* Initial commit of amp-standalone

* Add final features and test

* Fix types

* Fix tests

* Fix tests again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.