-
Notifications
You must be signed in to change notification settings - Fork 4k
♻️Introduce new detached dom writing logic. #26945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcordry
commented
Feb 24, 2020
calebcordry
commented
Feb 24, 2020
dvoytenko
suggested changes
Feb 25, 2020
dvoytenko
suggested changes
Mar 4, 2020
dvoytenko
approved these changes
Mar 9, 2020
|
Part of #27189 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splits logic handled by current
DomWriterinto two separate classes with some API changes.The first class
DetachedDomStreamexpects two callbacks (onChunk,onEnd) in its constructor, and handles taking the given chunks and writing them to an in memory document. It will pass the in memory doc to its callbacks.The second class
DomTransformStreamuses these two callbacks and exposes two methodswaitForHeadthat returns a promise of the head, andtransferBodywhich starts transferring elements from the detached doc to the given target element.