🧪Introduce a4a-no-signing experiment diversion #28690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Jiaming-X! These files were changed: Hey @jeffkaufman! These files were changed: |
lannka
reviewed
Jun 4, 2020
| this.startValidationFlow_(fetchResponse, checkStillCurrent) | ||
| getExperimentBranch(this.win, NO_SIGNING_EXP.id) === | ||
| NO_SIGNING_EXP.control | ||
| ? this.streamResponse_(fetchResponse) |
There was a problem hiding this comment.
Yikes, good catch. No idea why the tests passed.
There was a problem hiding this comment.
Oh I think its because this returns undefined
There was a problem hiding this comment.
ye, actually should change control to experiment, as @powerivq pointed out in the other comment.
powerivq
reviewed
Jun 4, 2020
extensions/amp-a4a/0.1/amp-a4a.js
Outdated
| .then((fetchResponse) => | ||
| this.startValidationFlow_(fetchResponse, checkStillCurrent) | ||
| getExperimentBranch(this.win, NO_SIGNING_EXP.id) === | ||
| NO_SIGNING_EXP.control |
There was a problem hiding this comment.
NO_SIGNING_EXP.experiment here?
lannka
approved these changes
Jun 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds diversion point, experiment will not be launched until logic is complete.
Part of #27189