🔄🗑🚮 Alias amp-story 0.1 to 1.0 and delete code #28776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsimha
approved these changes
Jun 9, 2020
gmajoulet
approved these changes
Jun 9, 2020
|
@jridgewell can you approve for bundle size? |
|
Has this been tested to ensure the basic functionality still works? |
|
Hmm not sure how to test this... In my local server I tried running |
I suspect this PR is incomplete. In addition to aliasing 0.1 to 1.0, don't you have to delete 0.1? See |
|
Don’t you have to delete the source code too? |
|
I was planning on doing that on a separate PR, if that's ok. I'd like this one to solely focus on the aliasing part as much as possible. |
rsimha
approved these changes
Jun 10, 2020
|
Actually I might have to delete the source code as part of this PR since pre-submit checks are complaining about not finding the deleted bundles. |
jridgewell
reviewed
Jun 11, 2020
|
Hey @gmajoulet, @newmuis! These files were changed: |
Enriqe
changed the title
|
Included the deleted source code changes, PTAL :) |
|
@jridgewell not sure why it says that
EDIT: it looks like it went away |
|
@jridgewell requesting approval for |
jridgewell
approved these changes
Jun 12, 2020
|
need approval from @ampproject/wg-caching |
Gregable
approved these changes
Jun 12, 2020
mszylkowski
pushed a commit
to mszylkowski/amphtml
that referenced
this pull request
Jun 17, 2020
* alias amp-story 0.1 to 1.0 * delete generation of 0.1 bundle * delete 0.1 code * deps, more code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for #28737 #14357
Closes #21251
Closes #14357
Closes #28737