🐛 Transforming stream race condition #29255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lannka
approved these changes
Jul 14, 2020
powerivq
approved these changes
Jul 14, 2020
dvoytenko
approved these changes
Jul 15, 2020
mszylkowski
pushed a commit
to mszylkowski/amphtml
that referenced
this pull request
Jul 22, 2020
* wait for body * types
proyectoramirez
pushed a commit
to proyectoramirez/amphtml
that referenced
this pull request
Jul 22, 2020
* wait for body * types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race where the response may finish (
onEndis called) before the target body is ready (transferBodyhas not been called). In this case we should wait for the target body before trying to transfer elements.Related to #27189