Skip to content

Move ads placement into layoutCallback of amp-auto-ads #29444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 23, 2020
Merged

Move ads placement into layoutCallback of amp-auto-ads #29444

merged 4 commits into from
Jul 23, 2020

Conversation

lannka
Copy link
Contributor

@lannka lannka commented Jul 22, 2020

Tests to be fixed.

Closes #27068

@lannka lannka requested a review from dvoytenko July 22, 2020 22:31
@google-cla google-cla bot added the cla: yes label Jul 22, 2020
@lannka lannka requested a review from calebcordry July 22, 2020 22:31
calebcordry
calebcordry approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@calebcordry calebcordry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was fast :)

@lannka lannka merged commit f7b5668 into ampproject:master Jul 23, 2020
@lannka lannka deleted the auto-ads-layoutcallback branch July 23, 2020 22:16
samouri pushed a commit to samouri/amphtml that referenced this pull request Jul 28, 2020
@lannka @samouri
Move ads placement into layoutCallback of amp-auto-ads (ampproject#29444
d050a49 
)

* Move ads placement into layoutCallback of amp-auto-ads

* add amp-access example

* fix check-types
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcordry calebcordry calebcordry approved these changes

+1 more reviewer

@dvoytenko dvoytenko dvoytenko approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes PR use: In Beta / Experimental
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Way to condition amp-auto-ads on amp-access
4 participants
@lannka @dvoytenko @calebcordry @ampprojectbot