Start an experiment to measure the impact of ads renderOnIdle feature. #31415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hey @jeffkaufman! These files were changed: |
calebcordry
approved these changes
Dec 3, 2020
|
Please take another look. I switched to mendel. |
calebcordry
reviewed
Dec 4, 2020
extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js
Show resolved
Hide resolved
powerivq
approved these changes
Dec 4, 2020
calebcordry
reviewed
Dec 4, 2020
| }, | ||
| { | ||
| experimentId: IDLE_CWV_EXP, | ||
| isTrafficEligible: () => () => { |
There was a problem hiding this comment.
is this intended to be a nested function?
calebcordry
approved these changes
Dec 4, 2020
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
ampproject#31415) * Start an experiment to measure the impact of ads renderOnIdle feature. * A better way to conduct this exp * isTrafficEligible * small refactor * filter out more ineligible traffic * no nested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #31436