✨[story-ads] Introduce new placement algorithm #33377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebcordry
commented
Mar 19, 2021
powerivq
reviewed
Mar 22, 2021
powerivq
approved these changes
Mar 24, 2021
|
@calebcordry This PR seems to have broken dependency checks: https://app.circleci.com/pipelines/github/ampproject/amphtml/5465/workflows/0d3541e6-3f34-49a1-bf1b-28fef021cece/jobs/74724/parallel-runs/0/steps/0-108 Perhaps a conflicting change snuck in after this was tested but before it was merged? |
|
@rsimha thanks for the heads up. Will send fix shortly. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Determines number of pages and insertion points upon page load. Monetizes shorter stories (>4 pages).
Partial #33147