Skip to content

🧪[story-ads] Start new placement algo exp #33471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 25, 2021
Merged

🧪[story-ads] Start new placement algo exp #33471

merged 4 commits into from
Mar 25, 2021

Conversation

calebcordry
Copy link
Member

partial #33147

@calebcordry calebcordry requested review from powerivq and lannka March 25, 2021 01:27
@amp-owners-bot amp-owners-bot bot requested a review from dvoytenko March 25, 2021 01:27
@amp-owners-bot
Copy link

Hey @Jiaming-X! These files were changed:

extensions/amp-ad-network-adsense-impl/0.1/amp-ad-network-adsense-impl.js

Hey @jeffkaufman! These files were changed:

extensions/amp-ad-network-adsense-impl/0.1/amp-ad-network-adsense-impl.js
extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js

@calebcordry calebcordry merged commit 43f29d5 into ampproject:master Mar 25, 2021
@calebcordry calebcordry deleted the start-placement-exp branch March 25, 2021 21:18
@calebcordry calebcordry mentioned this pull request Mar 29, 2021
Merged
@calebcordry calebcordry mentioned this pull request Mar 30, 2021
Open
rochapablo pushed a commit to rochapablo/amphtml that referenced this pull request Aug 30, 2021
@calebcordry @rochapablo
🧪[story-ads] Start new placement algo exp (ampproject#33471)
465507c 
* divert

* hook up

* google ads

* config files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powerivq powerivq Awaiting requested review from powerivq

2 more reviewers

@dvoytenko dvoytenko dvoytenko approved these changes

@lannka lannka lannka approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calebcordry @dvoytenko @lannka @ampprojectbot