Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃И[story ads] Start auto advance exp #33984

Merged
merged 7 commits into from
Apr 24, 2021

Conversation

calebcordry
Copy link
Member

Auto advancing story ads at 3 time intervals (6, 8, 10s) in order to determine monetization impact.

Partial #33969

@calebcordry calebcordry marked this pull request as ready for review April 23, 2021 18:25
@amp-owners-bot amp-owners-bot bot requested a review from dvoytenko April 23, 2021 18:26
@amp-owners-bot
Copy link

Hey @Jiaming-X! These files were changed:

extensions/amp-ad-network-adsense-impl/0.1/amp-ad-network-adsense-impl.js

Hey @jeffkaufman! These files were changed:

extensions/amp-ad-network-adsense-impl/0.1/amp-ad-network-adsense-impl.js
extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js

Copy link
Contributor

@lannka lannka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hoho, that's a log of boilerplate code to just turn on an experiment.

@calebcordry
Copy link
Member Author

hoho, that's a log of boilerplate code to just turn on an experiment.

Yep, we should maybe look into this :)

@calebcordry calebcordry merged commit 5f5a1ad into ampproject:main Apr 24, 2021
@calebcordry calebcordry deleted the auto-advance branch April 24, 2021 03:57
rochapablo pushed a commit to rochapablo/amphtml that referenced this pull request Aug 30, 2021
* introduce exp

* cleanup

* ad networks

* configs

* test

* merge cleanup

* jsdoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants