-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 amp-animation: Clarify prefers-reduced-motion #34442
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documenting publicly what we said privately:
This is too advanced for publishers to know about, think about, and too complex to write. We need to automatically solve this at the amp-story-animation
level for publishers.
@gmajoulet From our private chat as well. I fundamentally disagree with the approach being "too complicated", since the author includes the pre-animation CSS intentionally in any case. It's also exactly the way you have to do it on any document, it doesn't depend on our constraints nor the AMP format. What you're asking is not feasible at this level. Anything else would make the animations engine render-blocking, which is against our performance concerns. If you'd like to solely update the implementation for |
Two things:
|
Going to merge this PR as is and schedule some time for a followup conversation to discuss the points brought up. Thank you all for working to make this happen and looking forward to the next steps. |
Matias is working on a proper fix here: #34466 We know the ecosystem well enough to know that adding a few lines in the documentation and expect publishers to write complex code to solve something they don't even know of won't work. I don't think we need to meet to discuss this further. |
No description provided.