🧪[story-ads] Allow viewer to set progress bar segment experiment. #34827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Jiaming-X! These files were changed: Hey @jeffkaufman! These files were changed: Hey @gmajoulet, @newmuis! These files were changed: |
powerivq
approved these changes
Jun 11, 2021
calebcordry
force-pushed
the
story-next-up
branch
from
896091c
to
22dad01
Compare
calebcordry
force-pushed
the
story-next-up
branch
from
84183de
to
e591400
Compare
westonruter
added a commit
to westonruter/amphtml
that referenced
this pull request
Jun 16, 2021
…ebook-like-bento-version * 'main' of github.com:ampproject/amphtml: (23 commits) `amp-story-desktop-one-panel` Update demo with usecases (ampproject#34867) 🚮 Remove src/purifier.js rollup config (ampproject#34876) Validator Rollup (ampproject#34769) ✨ `amp-story-desktop-one-panel` Check UI type to get page dimension on tap (ampproject#34875) Refactor: move getRealChildNodes and getRealChildren to core (ampproject#34813) 🏗📖 Fix some example files that do not validate (ampproject#34835) 🏗Add `#test` and `#testing` to alias list (ampproject#34853) Add css files for missing components (ampproject#34861) Apply bulk transform to html tags (ampproject#34836) 🐛 amp-ima-video: Fix duration label on livestreams (ampproject#34865) ♻️ Extract `applyFillContent` into a standalone function (ampproject#34858) Give script tag closing tag (ampproject#34832) 🏗 Refinements to renovate config (ampproject#34862) Bento: Enable `SocialShare` for npm publishing (ampproject#34817) 🏗 Use aliased paths in generated extensions (ampproject#34860) ✨ `amp-story-desktop-one-panel` Position distance="2" page below viewport (ampproject#34834) 🏗 Set `wrapper` on generated Bento extensions (ampproject#34843) 🧪[story-ads] Allow viewer to set progress bar segment experiment. (ampproject#34827) 🏗 Allow extension bundles to specify their own wrapper (ampproject#34845) 🏗🚀 Speed up validated example grouping ~45x (ampproject#34837) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be a shared experiment between viewer and ads to determine user experience improvements, and monetization impact.
Partial #33969