Skip to content

Comments

🐛 [amp-story] Don't set auto-advance when in control#35006

Merged
calebcordry merged 1 commit intoampproject:mainfrom
calebcordry:viewer-fix
Jun 24, 2021
Merged

🐛 [amp-story] Don't set auto-advance when in control#35006
calebcordry merged 1 commit intoampproject:mainfrom
calebcordry:viewer-fix

Conversation

@calebcordry
Copy link
Member

999999ms is a special value passed from the viewer as the storyNextUp param that indicates we are in the control group of the auto advance experiment.

#33969

@calebcordry calebcordry requested a review from gmajoulet June 23, 2021 20:49
@amp-owners-bot
Copy link

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-page.js
extensions/amp-story/1.0/test/test-amp-story-page.js

@calebcordry
Copy link
Member Author

cc/ @zaparent

@calebcordry calebcordry merged commit ca24614 into ampproject:main Jun 24, 2021
@calebcordry calebcordry deleted the viewer-fix branch June 24, 2021 00:13
antiphoton pushed a commit to antiphoton/amphtml that referenced this pull request Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants