✨ [amp-analytics] Add Custom Browser Event Tracker #35193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmanek
reviewed
Jul 12, 2021
|
Revert and re-sync |
|
This pull request introduces 1 alert when merging d0f9b9c into 5e3ae41 - view on LGTM.com new alerts:
|
dmanek
reviewed
Jul 13, 2021
dmanek
reviewed
Jul 16, 2021
extensions/amp-analytics/0.1/test/test-custom-browser-events.js
Outdated
Show resolved
Hide resolved
extensions/amp-analytics/0.1/test/test-custom-browser-events.js
Outdated
Show resolved
Hide resolved
extensions/amp-analytics/0.1/test/test-custom-browser-events.js
Outdated
Show resolved
Hide resolved
extensions/amp-analytics/0.1/test/test-custom-browser-events.js
Outdated
Show resolved
Hide resolved
extensions/amp-analytics/0.1/test/test-custom-browser-events.js
Outdated
Show resolved
Hide resolved
erwinmombay
reviewed
Jul 20, 2021
alanorozco
reviewed
Jul 30, 2021
alanorozco
reviewed
Jul 30, 2021
alanorozco
requested changes
Aug 2, 2021
alanorozco
approved these changes
Aug 2, 2021
Co-authored-by: Alan Orozco <alanorozco@users.noreply.github.com>
dmanek
approved these changes
Aug 3, 2021
erwinmombay
approved these changes
Aug 3, 2021
westonruter
added a commit
to westonruter/amphtml
that referenced
this pull request
Aug 3, 2021
…tok-validation * 'main' of github.com:ampproject/amphtml: (72 commits) build: run amp lint --fix to address import order of jixie (ampproject#35513) ✨ [amp-analytics] Add Custom Browser Event Tracker (ampproject#35193) babel: teach amp mode transformer about #core/mode (ampproject#35477) 🚮 Remove experiment `amp-consent-granular-consent` (ampproject#35508) ♻️ Enable auto-sorting+grouping within src/ and 3p/ (ampproject#35454) 🐛 [amp-render] fix root-element stripping from amp-render with amp-bind (ampproject#35449) ✅ [Story interactive] Add Example Story for Detailed Results Component (ampproject#35450) 🐛 Fix error on bento example (ampproject#35490) 🐛 amp-story-grid-layer: Fix AMP invalidation error in documentation (ampproject#35503) 🐛 Fix code formatting (ampproject#35499) ✅ buildDom: add tests for amp-fit-text and amp-layout (ampproject#35494) ♻️ Remove unused imports (ampproject#35435) ✨ amp-connatix-player: iframe domain based on a property (ampproject#35179) Updated document with use cases of remote config (ampproject#35496) AMP.goBack: update documentation (ampproject#29290) 🏗 Allow the bundle-size job to run even if the builds were skipped (ampproject#35492) build-system: improve terser/esbuild integration (ampproject#35466) 🧪 [Story performance] Disable animations on first page to 50% (ampproject#35476) 📖 [Amp story] [Page attachments] Amp.dev Docs for New Page Attachment Features ampproject#34883 (ampproject#35338) 🚀 [Story interactive] Rewrite Image URL to Cached URL for Image Quizzes and Polls (ampproject#35375) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add a new feature to track a customizable set of triggers that are not currently supported by amp-analytics.
Comes in reponse to #17878
Currently several events are defined to be tracked by the amp analytics component. However, as noted in the thread there are still several events that are not supported by amp-analytcis. This project begins the process of adding custom browser events and supports future needs for analytics data on events.
The changes are currently added as an experiment in the PR.
Changes:
events.js- Add the custom browser event tracker for events blur and change
test-custom-browser-events.js- Add test for CBE tracker.
- Note: skipped over debounce to avoid waiting
amp-cbe.amp.html- Test page with two input fields and two dropdown menu.
- Tracks on-blur and on-change events on both elements.
Reviewer: @dmanek @alanorozco