Unify CacheState tracking for both legacy and remote video caching systems. #35252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @newmuis! These files were changed: |
gmajoulet
force-pushed
the
remote_video_cache_state
branch
from
1960040
to
ba1113c
Compare
mszylkowski
approved these changes
Jul 16, 2021
Comment on lines
435
to
440
| if (media.currentSrc === source.src && isCachedSource(source)) { | ||
| return CacheState.CACHE; | ||
| } | ||
| if (isCachedSource(source)) { | ||
| hasCachedSource = true; | ||
| } |
There was a problem hiding this comment.
Nit: To prevent defining the anon function, you could do
// All video caching mechanisms rely on HTMLSourceElements and never a src
// on the HTMLMediaElement as it does not allow for fallback sources.
const sources = toArray(media.querySelectorAll('source'));
let hasCachedSource = false;
for (const source of sources) {
if (source.hasAttribute('i-amphtml-video-cached-source')) {
// You can explain why this returns early so we understand when we look back at it (either this or the method documentation)
if (media.currentSrc === source.src) {
return CacheState.CACHE;
}
hasCachedSource = true;
}
}
return hasCachedSource ? CacheState.ORIGIN_CACHE_MISS : CacheState.ORIGIN;Also, keeping the declaration of hasCachedSource next to the loop will make it a bit easier to follow
There was a problem hiding this comment.
I'd like to kindly push back on the nested condition :( I agree that removing the anon function is cool, but my brain is really bad at following nested conditions or else statements (i.e. conditional conditions). This is why I always keep only one level of indentation, I found it to yield much much much easier to maintain code
There was a problem hiding this comment.
Still removed the anon function, thanks for the suggestion
gmajoulet
force-pushed
the
remote_video_cache_state
branch
from
ba1113c
to
edd0159
Compare
mszylkowski
approved these changes
Jul 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify
CacheStatetracking for both legacy and remote video caching systems.