Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃枍 [Story interactive] Text Shadow for Percentage Text for Image Quizzes and Polls #35324

merged 2 commits into from Jul 26, 2021


Copy link

Adds a text shadow behind the text that shows the percentage of users who selected each option in the post-selection state


/cc @mszylkowski
/cc @processprocess

@amp-owners-bot amp-owners-bot bot requested a review from newmuis July 20, 2021 22:31
Copy link

Hey @gmajoulet, @mszylkowski! These files were changed:


@mszylkowski mszylkowski requested review from processprocess and mszylkowski and removed request for newmuis July 20, 2021 22:36
@mszylkowski mszylkowski added this to In progress in wg-stories Sprint via automation Jul 20, 2021
Copy link

@mszylkowski mszylkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, even if the images had a lot of white and the accent color was light, the text is somewhat readable:

@processprocess processprocess merged commit 81fadb8 into ampproject:main Jul 26, 2021
wg-stories Sprint automation moved this from In progress to Done Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Successfully merging this pull request may close these issues.

None yet

4 participants