🖍 [Story interactive] Styling for Image Quizzes and Polls with Missing Images #35420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gmajoulet! These files were changed: Hey @mszylkowski! These files were changed: Hey @newmuis! These files were changed: |
mszylkowski
requested review from
mszylkowski and
processprocess
and removed request for
Enriqe
mszylkowski
reviewed
Jul 27, 2021
| @@ -924,6 +924,7 @@ amp-story .amp-video-eq, | |||
| --i-amphtml-interactive-component-shadow: 0px 4px 12px rgba(60, 64, 67, 0.08), 0px 2px 4px rgba(60, 64, 67, 0.12); | |||
| --i-amphtml-interactive-prompt-clamp: 4 !important; | |||
| --i-amphtml-interactive-results-prompt-margin: 20px !important; | |||
| --i-amphtml-interactive-missing-img-background: rgba(32, 33, 36, 0.2) !important; | |||
There was a problem hiding this comment.
We can call it --i-amphtml-interactive-placeholder-background so we can reuse these colors on the results component with the text bubbles
mszylkowski
approved these changes
Jul 27, 2021
processprocess
approved these changes
Jul 27, 2021
| @@ -924,6 +924,7 @@ amp-story .amp-video-eq, | |||
| --i-amphtml-interactive-component-shadow: 0px 4px 12px rgba(60, 64, 67, 0.08), 0px 2px 4px rgba(60, 64, 67, 0.12); | |||
| --i-amphtml-interactive-prompt-clamp: 4 !important; | |||
| --i-amphtml-interactive-results-prompt-margin: 20px !important; | |||
| --i-amphtml-interactive-placeholder-background: rgba(32, 33, 36, 0.2) !important; | |||
There was a problem hiding this comment.
nit: This might be more descriptive as:
--i-amphtml-interactive-img-placeholder-background
There was a problem hiding this comment.
As discussed in chat, we'll keep this as-is since it might be used for other contexts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Puts a background color in place of a missing image for image quizzes and image polls; the background color is a grey-ish color that depends on the theme of the component
Demos (see second-to-last and third-to-last pages):
https://interactive-img.web.app/missing-img/quiz.html
https://interactive-img.web.app/missing-img/poll.html
/cc @mszylkowski
/cc @processprocess