Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [Amp story player] [panel player] Launch panel player #35423

Merged
merged 9 commits into from Sep 23, 2021

Conversation

processprocess
Copy link
Contributor

@processprocess processprocess commented Jul 27, 2021

  • removes experiment flag to launch panel player
  • hides buttons when not in panel mode
  • removes desktop from variables

Closes #34765

@processprocess processprocess self-assigned this Jul 27, 2021
@processprocess processprocess added this to In progress in wg-stories Desktop One Panel via automation Jul 27, 2021
@processprocess processprocess added this to In Progress in wg-stories Player Jul 27, 2021
@processprocess processprocess changed the title ✨ [Amp story player] [Desktop panels player] Launch panel player ✨ [Amp story player] [panels player] Launch panel player Jul 28, 2021
@processprocess processprocess changed the title ✨ [Amp story player] [panels player] Launch panel player ✨ [Amp story player] [panel player] Launch panel player Jul 28, 2021
@processprocess processprocess added this to In progress in wg-stories Sprint via automation Jul 28, 2021
@gmajoulet
Copy link
Contributor

Is there anything I can help with to merge this?

@amp-owners-bot
Copy link

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story-player/0.1/test/test-e2e/test-amp-story-player-prerender.js

@processprocess processprocess merged commit 457b404 into ampproject:main Sep 23, 2021
wg-stories Player automation moved this from In Progress to Done Sep 23, 2021
wg-stories Sprint automation moved this from In progress to Done Sep 23, 2021
wg-stories Desktop One Panel automation moved this from In progress to Done Sep 23, 2021
@processprocess processprocess deleted the player-buttons branch September 23, 2021 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

amp-story-desktop-one-panel Integrate player into desktop one panel experience
3 participants