Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Reset page attachment scroll position upon attachment close #35778

Merged
merged 5 commits into from
Aug 24, 2021

Conversation

coreymasanto
Copy link
Contributor

Substitute the undefined this.state_ for this.state so that the page attachment's scroll position resets whenever the attachment closes, as intended.

@amp-owners-bot amp-owners-bot bot requested a review from raxsha August 23, 2021 21:49
@amp-owners-bot
Copy link

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-draggable-drawer.js

@mszylkowski mszylkowski requested review from mszylkowski and removed request for raxsha August 23, 2021 21:54
Copy link
Contributor

@gmajoulet gmajoulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gmajoulet gmajoulet merged commit 784577a into ampproject:main Aug 24, 2021
@gmajoulet gmajoulet added this to In progress in wg-stories Sprint via automation Aug 24, 2021
@gmajoulet gmajoulet moved this from In progress to Done in wg-stories Sprint Aug 24, 2021
@processprocess
Copy link
Contributor

Thank you for catching this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants