Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃枍 [Story performance] Remove standalone classes #36127

Merged
merged 18 commits into from Oct 8, 2021

Conversation

mszylkowski
Copy link
Contributor

@mszylkowski mszylkowski commented Sep 21, 2021

Replaces i-amphtml-story-standalone selectors with :root.

Closes #36049

@mszylkowski mszylkowski self-assigned this Sep 21, 2021
@mszylkowski mszylkowski added this to In progress in wg-stories Sprint via automation Sep 21, 2021
@amp-owners-bot
Copy link

amp-owners-bot bot commented Sep 21, 2021

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story.css
extensions/amp-story/1.0/amp-story.js
extensions/amp-story/1.0/test/test-amp-story.js

@newmuis
Copy link
Contributor

newmuis commented Sep 21, 2021

FYI the changes in this PR will drop specificity, which could cause breaking changes

@mszylkowski
Copy link
Contributor Author

Good point. The only thing that changes specificity for stories are the not !important styles which just seem to be the font-size for now, but font-sizes seem to be defined in 3 different places. I'm cleaning that up to just have that in one place (in this PR) but I could keep the specificity at the current value if we think it's useful.

The other properties changing specificity is not breaking anything, since they are all !important and keep the specificity in the right order

@mszylkowski mszylkowski merged commit 610583b into ampproject:main Oct 8, 2021
wg-stories Sprint automation moved this from In progress to Done Oct 8, 2021
@mszylkowski mszylkowski deleted the remove_runtimeclasses branch October 8, 2021 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[Story performance] Make CSS not rely on runtime classes
4 participants