Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Story devtools] Fixed validator not loading #36404

Merged
merged 4 commits into from
Oct 19, 2021

Conversation

mszylkowski
Copy link
Contributor

@mszylkowski mszylkowski commented Oct 18, 2021

Context: #36110
Closes: #34513

Due to the move to the wasm version of the validator, we need to initialize it before using it.

Without this change, the validator fails 20% of the time due to Web Assembly not being initialized.

@mszylkowski mszylkowski marked this pull request as ready for review October 19, 2021 15:44
@amp-owners-bot
Copy link

Hey @gmajoulet! These files were changed:

extensions/amp-story-dev-tools/0.1/amp-story-dev-tools-tab-debug.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Story devtools] Debug tab sometimes crashes if opening devtools from the preview tab
3 participants