Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust amp-ad sticky doubleclick arguments for parity #36457

Merged
merged 1 commit into from Oct 21, 2021

Conversation

powerivq
Copy link
Contributor

@powerivq powerivq commented Oct 21, 2021

It ensures that the ad requests will contain the same psz/msz arugments. @zombifier for approval.

Look like valueimpressions are duplicating the logics here. Changing it for them as well.

@amp-owners-bot
Copy link

Hey @jeffkaufman! These files were changed:

extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants