Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃殌 [Story performance] Remove media query matcher #36747

Merged
merged 4 commits into from
Nov 5, 2021

Conversation

mszylkowski
Copy link
Contributor

Closes #36695

We don't use the media query matcher, so we can remove it from the bundle

@amp-owners-bot
Copy link

amp-owners-bot bot commented Nov 3, 2021

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-media-query-service.js
extensions/amp-story/1.0/amp-story.css
extensions/amp-story/1.0/amp-story.js
extensions/amp-story/1.0/test/test-amp-story-media-query-service.js

@mszylkowski mszylkowski self-assigned this Nov 3, 2021
@mszylkowski mszylkowski added this to In progress in wg-stories Sprint via automation Nov 3, 2021

this.initializePromise_ = new Promise((resolve) => {
this.matcher_ = this.win_.document.createElement('iframe');
this.matcher_.classList.add('i-amphtml-story-media-query-matcher');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This CSS can be removed too

* @return {!AmpStoryMediaQueryService}
*/
export const getMediaQueryService = (win) => {
let service = Services.storyMediaQueryService(win);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed too from #service

@mszylkowski
Copy link
Contributor Author

@jridgewell for service/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

[Story] Remove media query matcher
4 participants