Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃摉 [Documentation] Added amp-video documentation that cache is not compatible with crossorigin #36772

Closed

Conversation

mszylkowski
Copy link
Contributor

To make sure people don't add the crossorigin attribute when using the video cache.

@mszylkowski mszylkowski self-assigned this Nov 4, 2021
@mszylkowski mszylkowski added this to In progress in wg-stories Sprint via automation Nov 4, 2021
@mszylkowski
Copy link
Contributor Author

This will soon change so I'm closing it (we will be able to use crossorigin with cached videos).

wg-stories Sprint automation moved this from In progress to Done Nov 17, 2021
@mszylkowski mszylkowski deleted the videoDocsCrossOriginOnCache branch December 9, 2021 21:21
@gmajoulet
Copy link
Contributor

Can you revert this now that the issue is fixed?

@mszylkowski
Copy link
Contributor Author

This was closed not merged, I closed it when we found out there was a fix for it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants