Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⏪ [Story system layer] Audio icon disappears when story has background audio #37314

Merged
merged 10 commits into from
Jan 7, 2022

Conversation

mszylkowski
Copy link
Contributor

@mszylkowski mszylkowski commented Jan 7, 2022

Reverts code from #37220 and adds unit test.

On experimental and beta, when the story only has background audio specified in the amp-story (example) the audio icon doesn't show due to the amp-story not reporting to the store service that the story element has background audio.

Will need to be cherry picked to experimental and beta, as this renders all background-audios on amp-story useless.

@amp-owners-bot
Copy link

amp-owners-bot bot commented Jan 7, 2022

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-store-service.js
extensions/amp-story/1.0/amp-story.js
extensions/amp-story/1.0/test/test-amp-story.js

@mszylkowski mszylkowski self-assigned this Jan 7, 2022
@mszylkowski mszylkowski added this to In progress in wg-stories Sprint via automation Jan 7, 2022
@mszylkowski mszylkowski merged commit bfa2191 into ampproject:main Jan 7, 2022
wg-stories Sprint automation moved this from In progress to Done Jan 7, 2022
@mszylkowski mszylkowski deleted the audioIconDIsappeared branch January 7, 2022 16:35
ampprojectbot pushed a commit that referenced this pull request Jan 7, 2022
…d audio (#37314)

* Added tasts

* Undo

* Reverted changes and added test

* Removed newlines between test

* Removed extra bracket

(cherry picked from commit bfa2191)
westonruter added a commit that referenced this pull request Jan 10, 2022
…nce-attr-to-hero-img

* 'main' of github.com:ampproject/amphtml: (525 commits)
  mathml storybook: supply missing component definition. (#37326)
  storybook: Iframe --> BentoIframe (#37327)
  🖍  [Story system layer] New ad badge (#37311)
  🐛 [amp story] Replay/next page button bug fix (#37316)
  🚀  [Story performance] Remove affiliate links (#37280)
  Compiler: Add amp-carousel-0.1 to the builder map (#37308)
  ⏪  [Story system layer] Audio icon disappears when story has background audio (#37314)
  🚀  [Story performance] Remove story access (#37281)
  Fix remapping esbuild output on Windows (#37312)
  🐛 adds in correct weight for amp-story-product-tag text (#37188)
  typechecking carousel: remove shame files (#37213)
  Use remapping to remap minified sourcemap into source code (#37238)
  SwG Release 0.1.22.199 (#37310)
  🐛 Adds microsoft-edge protocol (#34168)
  Sync for validator cpp engine and cpp htmlparser (#37292)
  ✨ amp-story-shopping Updated currency with product price and correct Localized currency (#37249)
  ✨[Smartadserver ad extension] Implement support for Fast Fetch (#36991)
  Remove client-side-experiments-config.json from this repo (#37304)
  🚮  Remove closure compiler logic from build-system. (#37296)
  🌐 Added RTL ordering i18n for amp story shopping tag (#37252)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants