📖 [Story analytics] Use amp-story-share-menu for share analytics
#37475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @cpauwels |
mszylkowski
changed the title
amp-story-share-menu for share analytics
|
Hey @gmajoulet, @newmuis! These files were changed: |
mszylkowski
changed the title
amp-story-share-menu for share analyticsamp-story-share-menu for share analytics
gmajoulet
approved these changes
Jan 25, 2022
rileyajones
pushed a commit
to rileyajones/amphtml
that referenced
this pull request
Jan 26, 2022
…mpproject#37475) * Added tasts * Undo * Adding share examples for analytics * Using share menu for analytics
samouri
pushed a commit
to samouri/amphtml
that referenced
this pull request
Feb 2, 2022
…mpproject#37475) * Added tasts * Undo * Adding share examples for analytics * Using share menu for analytics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sharing trigger was accidentally changed from
amp-story-share-menutoamp-story-share, reverting.Adding example configuration triggers for share menu opening, on
share.htmlandanalytics.htmlCloses #37446