🐛 [amp story shopping] Do not render shopping CTA if no shopping tags are on the page #37503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @gmajoulet! These files were changed: Hey @newmuis! These files were changed: |
mszylkowski
reviewed
Jan 27, 2022
processprocess
force-pushed
the
install
branch
from
530d7c1 to
9ec5aa3
Compare
gmajoulet
reviewed
Jan 28, 2022
mszylkowski
approved these changes
Feb 1, 2022
gmajoulet
approved these changes
Feb 1, 2022
samouri
pushed a commit
to samouri/amphtml
that referenced
this pull request
Feb 2, 2022
… are on the page (ampproject#37503) * Rename. Do not render CTA. * Update comment * Update test. * Remove unused * revert * revert * install in shopping attachment * check in layoutCallback * Move selectors to buildCallback. * Refert install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the attachment was refactored as part of #37278 to be a separate component and introduced a regression which was not caught since Percy diffs were broken at the time of submitting the PR.
This PR removes dead code that previously prevented the CTA from being built if no shopping-tags are on the page (originally done in #37004) and puts the functionality in amp-story-shopping-attachment.
It also renames
renderOpenAttachmentUI_toinstallPageAttachmentExtension_to better describe functionality.