Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨added camelCase to amp-story-shoppping component #37533

Merged
merged 4 commits into from
Feb 1, 2022
Merged

✨added camelCase to amp-story-shoppping component #37533

merged 4 commits into from
Feb 1, 2022

Conversation

jshamble
Copy link
Contributor

@jshamble jshamble commented Feb 1, 2022 •
edited
Loading

Add camelCase to amp-story-shopping component, as an accompaniment PR to the shopping config validation #37474

@amp-owners-bot amp-owners-bot bot requested a review from newmuis February 1, 2022 07:56
@amp-owners-bot
Copy link

amp-owners-bot bot commented Feb 1, 2022 •
edited
Loading

Hey @gmajoulet! These files were changed:

extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
extensions/amp-story-shopping/0.1/amp-story-shopping-config.js
extensions/amp-story-shopping/0.1/amp-story-shopping-tag.js
extensions/amp-story-shopping/0.1/test/test-amp-story-shopping-attachment.js
extensions/amp-story-shopping/0.1/test/test-amp-story-shopping-config.js
extensions/amp-story-shopping/0.1/test/test-amp-story-shopping-tag.js
extensions/amp-story/1.0/amp-story-store-service.js

Hey @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-store-service.js

@jshamble jshamble requested a review from coreymasanto February 1, 2022 08:06
@processprocess
Copy link
Contributor

Awesome succinct, scoped PR. Thank you!

@processprocess processprocess merged commit f96dc5e into ampproject:main Feb 1, 2022
samouri pushed a commit to samouri/amphtml that referenced this pull request Feb 2, 2022
@jshamble @samouri
✨added camelCase to amp-story-shoppping component (ampproject#37533)
c6419f7 
* added camelCase

* fixed find and replace bugs

* fixed find and replace bugs

* added correct class
@processprocess processprocess mentioned this pull request Feb 14, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@processprocess processprocess processprocess approved these changes

@newmuis newmuis Awaiting requested review from newmuis

@coreymasanto coreymasanto Awaiting requested review from coreymasanto

Assignees

@jshamble jshamble

Labels
P1: High Priority PR use: In Beta / Experimental PR use: In LTS PR use: In Stable Type: Refactoring WG: stories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jshamble @processprocess @ampprojectbot