Skip to content

Conversation

calebcordry
Copy link
Member

Gets rid of all the branches and puts everything behind a binary isExperimentOn() check. Also hardcodes the chosen time value of 10 seconds.

partial #33969

@calebcordry calebcordry requested a review from powerivq February 18, 2022 00:38
@amp-owners-bot amp-owners-bot bot requested a review from gmajoulet February 18, 2022 00:39
@amp-owners-bot
Copy link

Hey @Jiaming-X! These files were changed:

extensions/amp-ad-network-adsense-impl/0.1/amp-ad-network-adsense-impl.js

Hey @jeffkaufman! These files were changed:

extensions/amp-ad-network-adsense-impl/0.1/amp-ad-network-adsense-impl.js
extensions/amp-ad-network-doubleclick-impl/0.1/amp-ad-network-doubleclick-impl.js

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-page.js
extensions/amp-story/1.0/amp-story-system-layer.css
extensions/amp-story/1.0/progress-bar.js
extensions/amp-story/1.0/test/test-amp-story-page.js
extensions/amp-story/1.0/test/test-amp-story-progress-bar.js

@calebcordry calebcordry changed the title [story-ads] Cleanup auto progress experiment 🗑 [story-ads] Cleanup auto progress experiment Feb 18, 2022
@calebcordry calebcordry merged commit 3bcb983 into ampproject:main Feb 28, 2022
@calebcordry calebcordry deleted the advance-cleanup branch February 28, 2022 22:31
@ampprojectbot
Copy link
Member

Warning: disparity between this PR Percy build and its main build

The Percy build for this PR was approved (either manually by a member of the AMP team, or automatically if there were no visual diffs). However, during a continuous integration step we generated another Percy build using the commit on the main branch that this PR was merged into, and there appears to be a mismatch between the two.

This is possibly an indication of an issue with this pull request, but could also be the result of flakiness. Please inspect the two builds < This PR's Percy build / main commit's Percy build > and determine further action:

  • If the disparity appears to be caused by this PR, please create an bug report or send out a new PR to fix
  • If the disparity appears to be a flake, please @-mention ampproject/wg-approvers in a comment
  • If there is no disparity and this comment was created by mistake, please @-mention ampproject/wg-infra
  • If unsure, @-mention ampproject/wg-approvers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants