Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [AMP Story Paywall] Handles grant status and show/hide paywall dialog in amp-story-subscriptions #37892

Merged
merged 127 commits into from
Mar 31, 2022

Conversation

ychsieh
Copy link
Contributor

@ychsieh ychsieh commented Mar 17, 2022

  • Add the callback that handles grant status to be execute when 1) initial grant response during subscription service setup 2) all following grant response after users do actions like subscribe or log in.
  • Show/hide dialog UI when the dialog UI state is switched.

ychsieh and others added 30 commits January 20, 2022 18:19
Co-authored-by: Caleb Cordry <ccordry@google.com>
… validator in npm contains the new validator rule files in this PR.
…tion in AmpStoryPage to check if paywall protected. Also some fixes.
…ion to prevent the double loading issue of the new extension.
@ychsieh ychsieh marked this pull request as ready for review March 22, 2022 23:26
@calebcordry
Copy link
Member

We want to make sure to clean up state between tests, otherwise LGTM

Copy link
Contributor

@gmajoulet gmajoulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great 🏅

@gmajoulet gmajoulet added this to In progress in wg-stories Sprint via automation Mar 31, 2022
@ychsieh ychsieh merged commit 706a04b into ampproject:main Mar 31, 2022
wg-stories Sprint automation moved this from In progress to Done Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants