✨ [amp story captions] style-preset attribute with styles
#37967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
processprocess
force-pushed
the
captions-style
branch
from
0fb3e57 to
08d6642
Compare
processprocess
changed the title
data-preset attribute with styles
mszylkowski
reviewed
Apr 14, 2022
extensions/amp-story-captions/0.1/test/test-amp-story-captions.js
Outdated
Show resolved
Hide resolved
gmajoulet
reviewed
Apr 14, 2022
extensions/amp-story-captions/validator-amp-story-captions.protoascii
Outdated
Show resolved
Hide resolved
banaag
approved these changes
Apr 14, 2022
mszylkowski
reviewed
Apr 14, 2022
extensions/amp-story-captions/0.1/amp-story-captions-presets.css
Outdated
Show resolved
Hide resolved
mszylkowski
reviewed
Apr 14, 2022
mszylkowski
approved these changes
Apr 14, 2022
processprocess
changed the title
data-preset attribute with stylesstyle-preset attribute with styles
gmajoulet
approved these changes
Apr 18, 2022
|
|
||
| .amp-story-captions-default .amp-story-captions-cue-wrapper { | ||
| font-size: calc(2.5 * var(--story-page-vh, 8px)) !important; | ||
| font-family: 'Roboto', sans-serif !important; |
There was a problem hiding this comment.
Will this use Helvetica on iOS?
There was a problem hiding this comment.
|
Warning: disparity between this PR Percy build and its The Percy build for this PR was approved (either manually by a member of the AMP team, or automatically if there were no visual diffs). However, during a continuous integration step we generated another Percy build using the commit on the This is possibly an indication of an issue with this pull request, but could also be the result of flakiness. Please inspect the two builds < This PR's Percy build /
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows an optional
style-presetattribute that when defined and valid renders captions in shadow dom and adds custom styles.Adds tests.
Updates validation.
Implements the "default" and "appear" themes.
Appear theme has overridable
font-familyandfont-sizevalues using css variables.CSS variables are used so default values can be defined and overridden on the presets.
note: docs will need to be updated with how to set up and customize the default presets.
Demo pages 2 is "default" theme, page 3 is "appear" theme.
Default preset:
Appear preset (customized):
Closes #37900