Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚀 [Story localization] Asnyc all remaining usages of localization service [part 2] #37969

Merged
merged 35 commits into from
Mar 29, 2022
Merged

🚀 [Story localization] Asnyc all remaining usages of localization service [part 2] #37969

merged 35 commits into from
Mar 29, 2022

Conversation

mszylkowski
Copy link
Contributor

@mszylkowski mszylkowski commented Mar 28, 2022 •
edited
Loading

Follows #37947

I2I: #37344

@mszylkowski
Added tasts
6aabe91
@mszylkowski
Undo
dc1fa87
@mszylkowski
Merge branch 'main' of github.com:ampproject/amphtml
d707e5b
@mszylkowski
Merge branch 'main' of github.com:ampproject/amphtml
0e3df75
@mszylkowski
Merge branch 'main' of github.com:ampproject/amphtml
a3f7bd0
@mszylkowski
Merge branch 'main' of github.com:ampproject/amphtml
8c5119c
@mszylkowski
Merge branch 'main' of github.com:ampproject/amphtml
77f8435
@mszylkowski
Merge branch 'main' of github.com:ampproject/amphtml
16e712e
@mszylkowski
Merge branch 'main' of github.com:ampproject/amphtml
8088eb7
@mszylkowski
Merge branch 'main' of github.com:ampproject/amphtml
3858b2a
@mszylkowski
Merge branch 'main' of github.com:ampproject/amphtml
e12d2f6
@mszylkowski
Merge branch 'main' of github.com:ampproject/amphtml
2a29105
@mszylkowski
Merge branch 'main' of github.com:ampproject/amphtml
a5b781f
@mszylkowski
Merge branch 'main' of github.com:ampproject/amphtml
b8006ee
@mszylkowski
Merge branch 'main' of github.com:ampproject/amphtml
b570e86
@mszylkowski
Merge branch 'main' of github.com:ampproject/amphtml
6b7e456
@mszylkowski
Fixing stories usages of localization
60bd74e
@mszylkowski
Merge branch 'main' of github.com:ampproject/amphtml into localizeAll
df95bd4
@mszylkowski
Finished localizing and fixing test
b25b336
@mszylkowski
Fixed lints, interactive components
4f69f92
@mszylkowski
Fixed dep check
ab9d83b
@mszylkowski
Fixed tests
b6700e2
@mszylkowski
Remove unnecessary class
985e038
@mszylkowski
Remove unnecessary changes
4d7cc20
@mszylkowski
Merge branch 'main' of github.com:ampproject/amphtml into localizeAll
4c8ff8e
@mszylkowski
Merge branch 'main' of github.com:ampproject/amphtml into localizeAll
84c629b
@mszylkowski
Refactored localization in amp-tory
e8b0f82
@mszylkowski
Refactored all in amp-story
4042f93
@mszylkowski
Merge branch 'main' of github.com:ampproject/amphtml into localizeAll
10bb2a9
@mszylkowski
Fixed late install of attachment
9e4c848
@mszylkowski mszylkowski marked this pull request as ready for review March 28, 2022 19:16
@amp-owners-bot
Copy link

Hey @gmajoulet! These files were changed:

extensions/amp-story-page-attachment/0.1/amp-story-draggable-drawer.js
extensions/amp-story-page-attachment/0.1/amp-story-form.js
extensions/amp-story-page-attachment/0.1/amp-story-open-page-attachment.js
extensions/amp-story-page-attachment/0.1/amp-story-page-attachment.js
extensions/amp-story-page-attachment/0.1/test/test-amp-story-open-page-attachment.js
extensions/amp-story-page-attachment/0.1/test/test-amp-story-page-attachment.js
extensions/amp-story-share-menu/0.1/amp-story-share-menu.js
extensions/amp-story-shopping/0.1/amp-story-shopping-attachment.js
extensions/amp-story/1.0/pagination-buttons.js
extensions/amp-story/1.0/test/test-amp-story.js

Hey @newmuis! These files were changed:

extensions/amp-story-page-attachment/0.1/amp-story-draggable-drawer.js
extensions/amp-story-page-attachment/0.1/amp-story-form.js
extensions/amp-story-page-attachment/0.1/amp-story-open-page-attachment.js
extensions/amp-story-page-attachment/0.1/amp-story-page-attachment.js
extensions/amp-story-page-attachment/0.1/test/test-amp-story-open-page-attachment.js
extensions/amp-story-page-attachment/0.1/test/test-amp-story-page-attachment.js
extensions/amp-story-share-menu/0.1/amp-story-share-menu.js
extensions/amp-story/1.0/pagination-buttons.js
extensions/amp-story/1.0/test/test-amp-story.js

@mszylkowski mszylkowski removed the request for review from dvoytenko March 28, 2022 19:16
@mszylkowski @gmajoulet
Update extensions/amp-story-auto-ads/0.1/story-ad-localization.js
4f5025d 
Co-authored-by: Gabriel Majoulet <gmajoulet@google.com>
@mszylkowski
Copy link
Contributor Author

@erwinmombay for OWNERS on localization/index.js

@mszylkowski mszylkowski merged commit 6aa9ced into ampproject:main Mar 29, 2022
@mszylkowski mszylkowski deleted the localizeAll branch March 29, 2022 15:59
@jshamble jshamble mentioned this pull request Apr 8, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erwinmombay erwinmombay erwinmombay approved these changes

@gmajoulet gmajoulet gmajoulet approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mszylkowski @erwinmombay @gmajoulet @ampprojectbot