Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃枍 [Page Attachments] Add the 'Read more' string for translation #37991

Merged
merged 5 commits into from
Apr 4, 2022

Conversation

coreymasanto
Copy link
Contributor

As discussed in #36724, we are updating the default CTA for page attachments from "Swipe up" to "Read more". This PR adds this new "Read more" string in the appropriate places to be translated.

This string was previously added in this PR, but it was later mistakenly deprecated due to lack of use. Note that this new string will go unused until it has been translated, at which point I will create another PR to replace usages of "Swipe up" with "Read more".

@coreymasanto coreymasanto self-assigned this Mar 31, 2022
@coreymasanto coreymasanto marked this pull request as ready for review March 31, 2022 20:08
@amp-owners-bot
Copy link

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/_locales/en.json
src/service/localization/strings.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants