Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 [amp story captions] Update docs #38146

Merged
merged 6 commits into from
Apr 26, 2023

Conversation

processprocess
Copy link
Contributor

Updates amp-story-captions docs for official launch.
Corrects comment in css file.

@processprocess processprocess marked this pull request as ready for review April 27, 2022 15:25
@ychsieh
Copy link
Contributor

ychsieh commented Apr 25, 2023

@processprocess going to merge it within 24 hours. Feel free to reply here if there are actually some pending issues that I am not aware of : )

@ychsieh ychsieh merged commit 1e6e00e into ampproject:main Apr 26, 2023
@ampprojectbot
Copy link
Member

Warning: disparity between this PR Percy build and its main build

The Percy build for this PR was approved (either manually by a member of the AMP team, or automatically if there were no visual diffs). However, during a continuous integration step we generated another Percy build using the commit on the main branch that this PR was merged into, and there appears to be a mismatch between the two.

This is possibly an indication of an issue with this pull request, but could also be the result of flakiness. Please inspect the two builds < This PR's Percy build / main commit's Percy build > and determine further action:

  • If the disparity appears to be caused by this PR, please create an bug report or send out a new PR to fix
  • If the disparity appears to be a flake, please @-mention ampproject/wg-approvers in a comment
  • If there is no disparity and this comment was created by mistake, please @-mention ampproject/wg-infra
  • If unsure, @-mention ampproject/wg-approvers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants