-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [AMP Story Paywall] Validator changes to launch amp-story-subscriptions #38194
Conversation
Hey @newmuis, @gmajoulet, @ampproject/wg-caching! These files were changed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for validator changes.
attrs: { | ||
name: "description" | ||
mandatory: true | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll need to add the other supported fields as listed in your documentation, otherwise people can't use them: #38179
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thanks for the catch.
Warning: disparity between this PR Percy build and its The Percy build for this PR was approved (either manually by a member of the AMP team, or automatically if there were no visual diffs). However, during a continuous integration step we generated another Percy build using the commit on the This is possibly an indication of an issue with this pull request, but could also be the result of flakiness. Please inspect the two builds < This PR's Percy build /
|
…ions (ampproject#38194) * amp-story-subscriptions doc * merge * validator test * Add optional attributes
…ions (ampproject#38194) * amp-story-subscriptions doc * merge * validator test * Add optional attributes
No description provided.