Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [Story video] Prerendered video unmounted fails to play #38263

Merged
merged 34 commits into from
Jun 6, 2022

Conversation

mszylkowski
Copy link
Contributor

@mszylkowski mszylkowski commented Jun 2, 2022

Fixes #38227

Do not hide amp-video if it's already .i-amphtml-layout because that will unmount the component.

@mszylkowski mszylkowski self-assigned this Jun 2, 2022
@gmajoulet gmajoulet marked this pull request as ready for review June 2, 2022 19:44
@amp-owners-bot
Copy link

amp-owners-bot bot commented Jun 2, 2022

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story.css

@mszylkowski mszylkowski closed this Jun 3, 2022
@mszylkowski mszylkowski deleted the prerendervideo_unmount branch June 3, 2022 20:18
@mszylkowski mszylkowski restored the prerendervideo_unmount branch June 6, 2022 18:24
@mszylkowski mszylkowski reopened this Jun 6, 2022
@mszylkowski mszylkowski merged commit ec386c0 into ampproject:main Jun 6, 2022
@mszylkowski mszylkowski deleted the prerendervideo_unmount branch June 6, 2022 19:08
@ampprojectbot
Copy link
Member

Warning: disparity between this PR Percy build and its main build

The Percy build for this PR was approved (either manually by a member of the AMP team, or automatically if there were no visual diffs). However, during a continuous integration step we generated another Percy build using the commit on the main branch that this PR was merged into, and there appears to be a mismatch between the two.

This is possibly an indication of an issue with this pull request, but could also be the result of flakiness. Please inspect the two builds < This PR's Percy build / main commit's Percy build > and determine further action:

  • If the disparity appears to be caused by this PR, please create an bug report or send out a new PR to fix
  • If the disparity appears to be a flake, please @-mention ampproject/wg-approvers in a comment
  • If there is no disparity and this comment was created by mistake, please @-mention ampproject/wg-infra
  • If unsure, @-mention ampproject/wg-approvers

@llccrr
Copy link

llccrr commented Aug 4, 2022

Hello
@mszylkowski we are still experiencing the bug...

The story can be open here : https://smoon-lingerie.com/products/brassiere

Just tested on an iPhone 13 Pro Max with iOS 15.5

Bug.video.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video on first page freezes on the poster
4 participants