🔥 [Story videocache] Apply hasAudio flag behind experiment #38285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmajoulet
approved these changes
Jun 9, 2022
jridgewell
pushed a commit
that referenced
this pull request
Jun 10, 2022
* Apply hasAudio flag behind experiment * Added spec onto experiment config * Fixed unit tests (cherry picked from commit ed74a46)
ampprojectbot
pushed a commit
that referenced
this pull request
Jun 10, 2022
* Apply hasAudio flag behind experiment * Added spec onto experiment config * Fixed unit tests (cherry picked from commit ed74a46)
ampprojectbot
pushed a commit
that referenced
this pull request
Jun 10, 2022
* Apply hasAudio flag behind experiment * Added spec onto experiment config * Fixed unit tests (cherry picked from commit ed74a46)
ampprojectbot
pushed a commit
that referenced
this pull request
Jun 10, 2022
* Apply hasAudio flag behind experiment * Added spec onto experiment config * Fixed unit tests (cherry picked from commit ed74a46)
ampprojectbot
pushed a commit
that referenced
this pull request
Jun 10, 2022
* Apply hasAudio flag behind experiment * Added spec onto experiment config * Fixed unit tests (cherry picked from commit ed74a46)
ampprojectbot
pushed a commit
that referenced
this pull request
Jun 10, 2022
* Apply hasAudio flag behind experiment * Added spec onto experiment config * Fixed unit tests (cherry picked from commit ed74a46)
ampprojectbot
pushed a commit
that referenced
this pull request
Jun 10, 2022
* Apply hasAudio flag behind experiment * Added spec onto experiment config * Fixed unit tests (cherry picked from commit ed74a46)
ampprojectbot
pushed a commit
that referenced
this pull request
Jun 10, 2022
* Apply hasAudio flag behind experiment * Added spec onto experiment config * Fixed unit tests (cherry picked from commit ed74a46)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently many stories are being muted by the
hasAudioflag that the video cache returns, which is not accurate. We want to disable this feature and only enable it through a client-side experiment when the backend is fixed and the correct value is returned. This mutes videos on origin and cache (and there's no way to unmute them since the unmute icon is missing from the page).The experiment
story-video-cache-apply-audiowhen enabled will apply the audio flag that it receives from the cache.