From 68648b3863f20beddef51de5c9b73e97f44672de Mon Sep 17 00:00:00 2001 From: Shihua Zheng Date: Fri, 4 Oct 2024 21:35:33 +0800 Subject: [PATCH] =?UTF-8?q?Revert=20"=E2=9D=84=EF=B8=8F=20Disable=20flaky?= =?UTF-8?q?=20video=20player=20tests=20(#40114)"?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 19c14f4ed6d941e76382c4ecfdcd242097c8f3aa. --- test/integration/test-video-players-helper.js | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/test/integration/test-video-players-helper.js b/test/integration/test-video-players-helper.js index e31678359f51..51662357e93f 100644 --- a/test/integration/test-video-players-helper.js +++ b/test/integration/test-video-players-helper.js @@ -179,8 +179,7 @@ export function runVideoPlayerIntegrationTests( }); }); - // TODO(#40115): fix this flaky test - it.skip('should trigger pause analytics when the video pauses', function () { + it('should trigger pause analytics when the video pauses', function () { let pauseButton; return getVideoPlayer({ @@ -202,8 +201,7 @@ export function runVideoPlayerIntegrationTests( }); }); - // TODO(#40115): fix this flaky test - it.skip('should trigger session analytics when a session ends', function () { + it('should trigger session analytics when a session ends', function () { let pauseButton; return getVideoPlayer({ @@ -381,8 +379,7 @@ export function runVideoPlayerIntegrationTests( this.timeout(timeout); describe('play/pause', () => { - // TODO(#40115): fix this flaky test - it.skip('should play when in view port initially', () => { + it('should play when in view port initially', () => { return getVideoPlayer({outsideView: false, autoplay: true}).then( (r) => { return listenOncePromise(r.video, VideoEvents_Enum.PLAYING);