Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Optimize YT loading
- render some players outside the first viewport (but less than the 3 default viewports, see comment)
- preload the player HTML (this can now be done, because we never preload in prerender where we don't allowed cookied domains like youtube.com)

Unrelated change: Remove long deprecated method in preconnect.js
  • Loading branch information
cramforce committed Sep 14, 2016
commit c324bcf07ee7acdb2988702f8a6b0226354f9257
17 changes: 13 additions & 4 deletions extensions/amp-youtube/0.1/amp-youtube.js
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class AmpYoutube extends AMP.BaseElement {
* @override
*/
preconnectCallback(opt_onLayout) {
this.preconnect.url('https://www.youtube.com', opt_onLayout);
this.preconnect.preload(this.getVideoIframeSrc_(), opt_onLayout);
// Host that YT uses to serve JS needed by player.
this.preconnect.url('https://s.ytimg.com', opt_onLayout);
// Load high resolution placeholder images for videos in prerender mode.
Expand All @@ -66,7 +66,11 @@ class AmpYoutube extends AMP.BaseElement {

/** @override */
renderOutsideViewport() {
return false;
// We are conservative about loading YT videos outside the viewport,
// because the player is pretty heavy.
// This will still start loading before they become visible, but it
// won't typically load a large number of embeds.
return 0.75;
}

/** @override */
Expand All @@ -81,13 +85,18 @@ class AmpYoutube extends AMP.BaseElement {
}
}

/** @return {string} */
getVideoIframeSrc_() {
dev().assert(this.videoid_);
return `https://www.youtube.com/embed/${encodeURIComponent(this.videoid_ || '')}?enablejsapi=1`;
}

/** @override */
layoutCallback() {
// See
// https://developers.google.com/youtube/iframe_api_reference
const iframe = this.element.ownerDocument.createElement('iframe');
dev().assert(this.videoid_);
let src = `https://www.youtube.com/embed/${encodeURIComponent(this.videoid_ || '')}?enablejsapi=1`;
let src = this.getVideoIframeSrc_();

const params = getDataParamsFromAttributes(this.element);
if ('autoplay' in params) {
Expand Down
12 changes: 0 additions & 12 deletions src/preconnect.js
Original file line number Diff line number Diff line change
Expand Up @@ -134,18 +134,6 @@ export class Preconnect {
this.preconnectPolyfill_(origin);
}

/**
* Temporary to not break prod when versions are misaligned across binaries.
* DO NOT USE!
* This should be safe to remove 1 version after 1468017284333 hits prod.
* @param {string} url
* @param {string=} opt_preloadAs
* @deprecated
*/
prefetch(url, opt_preloadAs) {
this.preload(url, opt_preloadAs);
}

/**
* Asks the browser to preload a URL. Always also does a preconnect
* because browser support for that is better.
Expand Down