Skip to content

Optimize YT loading #5003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 15, 2016
Merged

Optimize YT loading #5003

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c324bcf
Optimize YT loading
cramforce Sep 14, 2016
fd612a8
Fix type (and actual) error.
cramforce Sep 15, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions extensions/amp-youtube/0.1/amp-youtube.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ class AmpYoutube extends AMP.BaseElement {
* @override
*/
preconnectCallback(opt_onLayout) {
this.preconnect.url('https://www.youtube.com', opt_onLayout);
this.preconnect.preload(this.getVideoIframeSrc_(), opt_onLayout);
// Host that YT uses to serve JS needed by player.
this.preconnect.url('https://s.ytimg.com', opt_onLayout);
// Load high resolution placeholder images for videos in prerender mode.
Expand All @@ -66,7 +66,11 @@ class AmpYoutube extends AMP.BaseElement {

/** @override */
renderOutsideViewport() {
return false;
// We are conservative about loading YT videos outside the viewport,
// because the player is pretty heavy.
// This will still start loading before they become visible, but it
// won't typically load a large number of embeds.
return 0.75;
}

/** @override */
Expand All @@ -81,13 +85,18 @@ class AmpYoutube extends AMP.BaseElement {
}
}

/** @return {string} */
getVideoIframeSrc_() {
dev().assert(this.videoid_);
return `https://www.youtube.com/embed/${encodeURIComponent(this.videoid_ || '')}?enablejsapi=1`;
}

/** @override */
layoutCallback() {
// See
// https://developers.google.com/youtube/iframe_api_reference
const iframe = this.element.ownerDocument.createElement('iframe');
dev().assert(this.videoid_);
let src = `https://www.youtube.com/embed/${encodeURIComponent(this.videoid_ || '')}?enablejsapi=1`;
let src = this.getVideoIframeSrc_();

const params = getDataParamsFromAttributes(this.element);
if ('autoplay' in params) {
Expand Down
12 changes: 0 additions & 12 deletions src/preconnect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,18 +134,6 @@ export class Preconnect {
this.preconnectPolyfill_(origin);
}

/**
* Temporary to not break prod when versions are misaligned across binaries.
* DO NOT USE!
* This should be safe to remove 1 version after 1468017284333 hits prod.
* @param {string} url
* @param {string=} opt_preloadAs
* @deprecated
*/
prefetch(url, opt_preloadAs) {
this.preload(url, opt_preloadAs);
}

/**
* Asks the browser to preload a URL. Always also does a preconnect
* because browser support for that is better.
Expand Down