Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support target protocol in templates #5738

Merged
merged 4 commits into from Oct 21, 2016
Merged

Conversation

dvoytenko
Copy link
Contributor

Closes #1572.

Copy link
Contributor

@mkhatib mkhatib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one change

}
}
let origTarget = savedAttribs[index];
if (origTarget != null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

savedAttribs[-1] will be undefined not null.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which thinking about it this still should be ok.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd work, but you are right - better to be explicit. Fixed.

@dvoytenko dvoytenko merged commit c867987 into ampproject:master Oct 21, 2016
@dvoytenko dvoytenko deleted the target4 branch October 21, 2016 01:02
Lith pushed a commit to Lith/amphtml that referenced this pull request Dec 22, 2016
* Support target protocol in templates

* cleanup

* linter

* fixing tests
Lith pushed a commit to Lith/amphtml that referenced this pull request Dec 22, 2016
* Support target protocol in templates

* cleanup

* linter

* fixing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants